Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add postgresql 2023-06-01-preview API #3357

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Add postgresql 2023-06-01-preview API #3357

merged 1 commit into from
Nov 16, 2023

Conversation

timja
Copy link
Contributor

@timja timja commented Nov 16, 2023 •
edited
Loading

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

tombuildsstuff
tombuildsstuff approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@timja
Copy link
Contributor Author

timja commented Nov 16, 2023

🚢 ? 😄

@tombuildsstuff
Copy link
Contributor

@timja in a queue (#3358 needs to go first) - but shortly :)

@tombuildsstuff tombuildsstuff merged commit 0e043a9 into hashicorp:main Nov 16, 2023
3 checks passed
@timja timja deleted the patch-1 branch November 16, 2023 10:53
@timja
Copy link
Contributor Author

timja commented Nov 16, 2023

Did I miss something? It hasn't seemed to have generated the API in https://github.com/hashicorp/pandora/tree/main/api-definitions/resource-manager/PostgreSql

@tombuildsstuff
Copy link
Contributor

@timja there's a data fix needed - #3361 - once that's merged the API Definitions will be regenerated (example #3360) and then once that's merged hashicorp/go-azure-sdk gets regenerated - should be there in a bit

@tombuildsstuff
Copy link
Contributor

@timja FYI hashicorp/go-azure-sdk#741 - once the PR's merged hashicorp/go-azure-sdk will release itself, then update hashicorp/terraform-provider-azurerm and (try to) update the postgres package fwiw

@tombuildsstuff
Copy link
Contributor

Ah alas looks like there might be a breaking change in the new psql version, but the SDK is being upgraded in this PR: hashicorp/terraform-provider-azurerm@7fcfd18

@timja timja mentioned this pull request Nov 24, 2023
Merged
@timja
Copy link
Contributor Author

timja commented Nov 24, 2023

Ah alas looks like there might be a breaking change in the new psql version, but the SDK is being upgraded in this PR: hashicorp/terraform-provider-azurerm@7fcfd18

weird, I didn't hit any issues when I upgraded it:
hashicorp/terraform-provider-azurerm#24016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timja @hashicorp-cla @tombuildsstuff